Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Fix: bibkey generated does not handle diacritics"" #4742

Merged
merged 1 commit into from
Mar 10, 2019

Conversation

Siedlerchr
Copy link
Member

Reverts #4741

@Siedlerchr Siedlerchr merged commit fac6e62 into master Mar 10, 2019
Siedlerchr added a commit that referenced this pull request Mar 10, 2019
* upstream/master:
  Revert "Revert "Fix: bibkey generated does not handle diacritics" (#4741)" (#4742)
  Revert "Fix: bibkey generated does not handle diacritics" (#4741)
  Rename method to removeUnwantedCharacters
  Remove the dashes from test case
  Remove -s from key
  Update test cases
  Filter unwanted characters before removing whitespaces
  Fix NotOnJavaFXThread exception for remote import
  Remove old swing-based tests
  Extract authN method
  Shift cleaning of authString to authN only
  Clean key in BracketedPattern after author value is retrieved
Siedlerchr added a commit that referenced this pull request Mar 16, 2019
…erbibtexkey

* upstream/master: (827 commits)
  [#4306] Disable renaming (#4727)
  Feature: implement search filter in show preferences (#4759)
  Enable import button only if entry selected (#4761)
  Improve Remote messaging (#4760)
  Add changelog entry for #4520
  Modifications to improve contrast of UI elements (#4758)
  Rework external changes dialog in JavaFX (#4693)
  Changes the title of Group Dialog to Add subgroup when adding a new subgroup (#4757)
  Optimize data fetching (#4520)
  Adds a browse button next to the path text field for aux-based groups (#4743)
  Saving changes and exiting application (#4729)
  Code optimized and created a reusable method to get writer output (#4750)
  Bump mvvmfx from 1.7.0 to 1.8.0 (#4747)
  Bump guava from 27.0.1-jre to 27.1-jre (#4748)
  Bump mvvmfx-validation from 1.7.0 to 1.8.0 (#4749)
  Remove obsolete swing components in Preferences and OpenOffice (#4740)
  Move library specific key pattern dialog call to library menu (#4744)
  Revert "Revert "Fix: bibkey generated does not handle diacritics" (#4741)" (#4742)
  Revert "Fix: bibkey generated does not handle diacritics" (#4741)
  Rename method to removeUnwantedCharacters
  ...
@stefan-kolb stefan-kolb deleted the revert-4741-revert-4713-handling-diacritics-4709 branch August 23, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant